New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow Symfony 5 #766
Allow Symfony 5 #766
Conversation
890c24e
to
b19d2aa
Compare
I haven't kept up with Symfony 5 release documentation. Are there no API changes/breaks? |
Symfony is supposed to break indeed. But it looks like it doesn't impact ratchet. I tested this patch:
With the following wstest config in {
"outdir": "./reports/servers",
"servers": [
{
"url": "ws://127.0.0.1:8000"
}
],
"cases": ["*"],
"exclude-cases": [],
"exclude-agent-cases": {}
}
Everything is green. (artifacts zipped joined) |
I also run in against static analysis and everything seems to be compatible |
Considering it looks like it's covered by the tests I doubt there will be issues |
Any news here? |
+1 |
Wow, neat! |
I think, it’s a good point to make a release with that change. |
v0.4.2 has been tagged - thanks! |
@mbonneau, as I can see, there is small mistake - you're add version 0.4.2, but in the ConnectionInterface const version set to 'Ratchet/0.4.1' |
No description provided.