Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Symfony 5 #766

Merged
merged 1 commit into from Jan 27, 2020
Merged

Allow Symfony 5 #766

merged 1 commit into from Jan 27, 2020

Conversation

simPod
Copy link
Contributor

@simPod simPod commented Nov 22, 2019

No description provided.

@cboden
Copy link
Member

cboden commented Nov 30, 2019

I haven't kept up with Symfony 5 release documentation. Are there no API changes/breaks?

@Nek-
Copy link

Nek- commented Nov 30, 2019

Symfony is supposed to break indeed. But it looks like it doesn't impact ratchet.

I tested this patch:

git remote add simpod git@github.com:simPod/Ratchet.git
git fetch simpod
git checkout allow-symfony-5
composer install

With the following wstest config in fuzzingclient.json:

{
   "outdir": "./reports/servers",
   "servers": [
      {
         "url": "ws://127.0.0.1:8000"
      }
   ],
   "cases": ["*"],
   "exclude-cases": [],
   "exclude-agent-cases": {}
}
php tests/autobahn/bin/fuzzingserver.php &
wstest -m fuzzingclient

Everything is green. (artifacts zipped joined)
reports.zip

@simPod
Copy link
Contributor Author

simPod commented Nov 30, 2019

I also run in against static analysis and everything seems to be compatible

@WyriHaximus
Copy link

Considering it looks like it's covered by the tests I doubt there will be issues

@pyatnitsev
Copy link

Any news here?

@ricardoboss
Copy link

+1

@mbonneau mbonneau merged commit 57721e1 into ratchetphp:master Jan 27, 2020
@simPod
Copy link
Contributor Author

simPod commented Jan 27, 2020

Wow, neat!

@simPod simPod deleted the allow-symfony-5 branch January 27, 2020 23:09
@pyatnitsev
Copy link

I think, it’s a good point to make a release with that change.

@mbonneau
Copy link
Member

v0.4.2 has been tagged - thanks!

@pyatnitsev
Copy link

@mbonneau, as I can see, there is small mistake - you're add version 0.4.2, but in the ConnectionInterface const version set to 'Ratchet/0.4.1'

@mbonneau mbonneau self-assigned this Mar 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants